third_party/WebKit/Source/core/paint/SVGShapePainter.cpp - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't end recording twice in DrawingRecorder. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp ('K') | « third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp b/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

index 164a531636222a5ade29705fcbeb3e057d7aa535..7b8de068ee80276e0788c4146ee800412a766179 100644

--- a/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

@@ -204,7 +204,9 @@ void SVGShapePainter::paintMarkers(const PaintInfo& paintInfo, const FloatRect&

markerPaintInfo.m_cullRect.m_rect = LayoutRect::infiniteIntRect();

paintMarker(markerPaintInfo, *marker, (*markerPositions)[i], strokeWidth);

- pictureBuilder.endRecording()->playback(paintInfo.context.canvas());

+ RefPtr<const SkPicture> recording = pictureBuilder.endRecording();

+ if (recording)

+ recording->playback(paintInfo.context.canvas());

}