third_party/WebKit/Source/core/paint/SVGClipPainter.cpp - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGClipPainter.cpp

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't end recording twice in DrawingRecorder. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp ('k') | third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGClipPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp b/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp

index 806cad631f9bcec3e41a5356a486cf659604acad..e36ea76bf463a69dd852c98fd12055bf26b61a9f 100644

--- a/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGClipPainter.cpp

@@ -127,7 +127,8 @@ bool SVGClipPainter::drawClipAsMask(GraphicsContext& context, const LayoutObject

TransformRecorder contentTransformRecorder(maskContext, layoutObject, contentTransform);

RefPtr<const SkPicture> clipContentPicture = m_clip.createContentPicture();

- maskContext.getPaintController().createAndAppend<DrawingDisplayItem>(layoutObject, DisplayItem::SVGClip, clipContentPicture.get());

+ if (clipContentPicture)

+ maskContext.getPaintController().createAndAppend<DrawingDisplayItem>(layoutObject, DisplayItem::SVGClip, clipContentPicture.get());

}

if (clipPathClipper)

@@ -136,7 +137,8 @@ bool SVGClipPainter::drawClipAsMask(GraphicsContext& context, const LayoutObject

LayoutObjectDrawingRecorder drawingRecorder(context, layoutObject, DisplayItem::SVGClip, targetPaintInvalidationRect);

RefPtr<SkPicture> maskPicture = maskPictureBuilder.endRecording();

- context.drawPicture(maskPicture.get());

+ if (maskPicture)

+ context.drawPicture(maskPicture.get());

return true;

}