third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't end recording twice in DrawingRecorder. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h

index bbc5e9ed13adb9450ea3bf008a30116115415f6a..5c349a98e826a57365152e759a30009667b322a2 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.h

@@ -50,6 +50,8 @@ public:

static const LayoutSVGResourceType s_resourceType = MaskerResourceType;

LayoutSVGResourceType resourceType() const override { return s_resourceType; }

+ // Returns a picture to paint the contents of the mask, or nullptr if the picture couldn't be created.

+ // Pictures should only fail creation in certain testing situations.

PassRefPtr<const SkPicture> createContentPicture(AffineTransform&, const FloatRect&, GraphicsContext&);

private: