Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContext.h

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsContext.h
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContext.h b/third_party/WebKit/Source/platform/graphics/GraphicsContext.h
index 1cf648d8dad969a124dbf56a26af869171d70246..7d7c3f6362fa33065162d7c0626a7353508c56a6 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsContext.h
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContext.h
@@ -211,6 +211,8 @@ public:
// are stored in a display list that can be replayed at a later time. Pass in the bounding
// rectangle for the content in the list.
void beginRecording(const FloatRect&);
+ // Returns a picture with any recorded draw commands since the prerequisite call to beginRecording(),
+ // or nullptr if the canvas is disabled.
chrishtr 2016/03/29 22:42:23 add the second sentence
wkorman 2016/03/29 22:52:02 Done, more specific phrasing here since this is th
PassRefPtr<SkPicture> endRecording();
void setShadow(const FloatSize& offset, float blur, const Color&,

Powered by Google App Engine
This is Rietveld 408576698