third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 1841833002: Deal gracefully with null {GraphicsContext,SkPictureBuilder}.endRecording() results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 0af4a42a5d0efc3503cd12ac3a165ce81a025d3e..23de22884b5d4fd69431b5135807a84e7165f8f9 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -127,6 +127,9 @@ public:

m_draggedNode->layoutObject()->updateDragState(false);

context().getPaintController().endItem<EndTransformDisplayItem>(*m_localFrame);

RefPtr<const SkPicture> recording = m_pictureBuilder->endRecording();

+ if (!recording)

chrishtr 2016/03/29 22:42:23 Did you check call sites to be robust aginst nullp

wkorman 2016/03/29 22:52:02 Yes.

+ return nullptr;

RefPtr<SkImage> skImage = adoptRef(SkImage::NewFromPicture(recording.get(),

SkISize::Make(m_bounds.width(), m_bounds.height()), nullptr, nullptr));

RefPtr<Image> image = StaticBitmapImage::create(skImage.release());