Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Unified Diff: Tools/Scripts/webkitpy/test/printer.py

Issue 18418010: Check in the thirdparty libs needed for webkitpy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/test/main_unittest.py ('k') | Tools/Scripts/webkitpy/test/runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/test/printer.py
diff --git a/Tools/Scripts/webkitpy/test/printer.py b/Tools/Scripts/webkitpy/test/printer.py
index f4a4b06acb575fce19e2765f46dded0ebda221bc..0cb02af10dc4cfd48f88fc19d578a5108578967e 100644
--- a/Tools/Scripts/webkitpy/test/printer.py
+++ b/Tools/Scripts/webkitpy/test/printer.py
@@ -82,13 +82,8 @@ class Printer(object):
# Messages can be selectively re-enabled for this script by updating
# this method accordingly.
def filter_records(record):
- """Filter out autoinstall and non-third-party webkitpy messages."""
- # FIXME: Figure out a way not to use strings here, for example by
- # using syntax like webkitpy.test.__name__. We want to be
- # sure not to import any non-Python 2.4 code, though, until
- # after the version-checking code has executed.
- if (record.name.startswith("webkitpy.common.system.autoinstall") or
- record.name.startswith("webkitpy.test")):
+ """Filter out non-third-party webkitpy messages."""
+ if record.name.startswith("webkitpy.test"):
return True
if record.name.startswith("webkitpy"):
return False
« no previous file with comments | « Tools/Scripts/webkitpy/test/main_unittest.py ('k') | Tools/Scripts/webkitpy/test/runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698