Issue 18418009: FileAPI: Add FileObserver related interfaces into FileSystemQuotaUtil

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18418009: FileAPI: Add FileObserver related interfaces into FileSystemQuotaUtil (Closed)

Created:
7 years, 5 months ago by nhiroki

Modified:
7 years, 5 months ago

Reviewers:
kinuko, tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

FileAPI: Add FileObserver related interfaces into FileSystemQuotaUtil This change adds FileObserver related interfaces into FileSystemQuotaUtil and adapts existing functions in SandboxFileSystemBackend and TestFileSystemBackend to them. These functions are used only in sandbox filesystem and we are moving all of those kinds of functions to FileSystemQuotaUtil so that other backends don't have to take care of them. BUG=242422 TEST=content_unittests R=kinuko@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211332

Patch Set 1 : #

Patch Set 2 : rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -70 lines)			Patch
M	webkit/browser/fileapi/file_system_quota_util.h	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_system_backend.h	View	1	1 chunk	+24 lines, -16 lines	0 comments	Download
M	webkit/browser/fileapi/sandbox_file_system_backend.cc	View	1	2 chunks	+59 lines, -39 lines	0 comments	Download
M	webkit/browser/fileapi/test_file_system_backend.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/test_file_system_backend.cc	View	1	6 chunks	+67 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/18418009/16002

7 years, 5 months ago (2013-07-12 04:03:47 UTC) #4

nhiroki

7 years, 5 months ago (2013-07-12 05:14:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r211332 (presubmit successful).

Expand Messages | Collapse Messages