Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: content/browser/bluetooth/bluetooth_dispatcher_host.cc

Issue 1841763002: Add a kill switch for all of Web Bluetooth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Sync and rename an enum value. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | content/browser/bluetooth/bluetooth_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/bluetooth/bluetooth_dispatcher_host.cc
diff --git a/content/browser/bluetooth/bluetooth_dispatcher_host.cc b/content/browser/bluetooth/bluetooth_dispatcher_host.cc
index ed47a5a843bfb3815c98e651aa51048aafde6157..204c5dc6e436a99a62a04d611a393b2a855d8609 100644
--- a/content/browser/bluetooth/bluetooth_dispatcher_host.cc
+++ b/content/browser/bluetooth/bluetooth_dispatcher_host.cc
@@ -1230,14 +1230,32 @@ void BluetoothDispatcherHost::OnRequestDeviceImpl(
return;
}
- if (!GetContentClient()->browser()->AllowWebBluetooth(
- web_contents->GetBrowserContext(), requesting_origin,
- embedding_origin)) {
- RecordRequestDeviceOutcome(
- UMARequestDeviceOutcome::BLUETOOTH_CHOOSER_GLOBALLY_DISABLED);
- Send(new BluetoothMsg_RequestDeviceError(
- thread_id, request_id, WebBluetoothError::CHOOSER_DISABLED));
- return;
+ switch (GetContentClient()->browser()->AllowWebBluetooth(
+ web_contents->GetBrowserContext(), requesting_origin, embedding_origin)) {
+ case ContentBrowserClient::AllowWebBluetoothResult::BLOCK_POLICY: {
+ RecordRequestDeviceOutcome(
+ UMARequestDeviceOutcome::BLUETOOTH_CHOOSER_POLICY_DISABLED);
+ Send(new BluetoothMsg_RequestDeviceError(
+ thread_id, request_id,
+ WebBluetoothError::CHOOSER_NOT_SHOWN_API_LOCALLY_DISABLED));
+ return;
+ }
+ case ContentBrowserClient::AllowWebBluetoothResult::
+ BLOCK_GLOBALLY_DISABLED: {
+ // Log to the developer console.
+ web_contents->GetMainFrame()->AddMessageToConsole(
+ content::CONSOLE_MESSAGE_LEVEL_LOG,
+ "Bluetooth permission has been blocked.");
+ // Block requests.
+ RecordRequestDeviceOutcome(
+ UMARequestDeviceOutcome::BLUETOOTH_GLOBALLY_DISABLED);
+ Send(new BluetoothMsg_RequestDeviceError(
+ thread_id, request_id,
+ WebBluetoothError::CHOOSER_NOT_SHOWN_API_GLOBALLY_DISABLED));
+ return;
+ }
+ case ContentBrowserClient::AllowWebBluetoothResult::ALLOW:
+ break;
}
// Create storage for the information that backs the chooser, and show the
@@ -1390,7 +1408,7 @@ void BluetoothDispatcherHost::FinishClosingChooser(
VLOG(1) << "Bluetooth chooser denied permission";
Send(new BluetoothMsg_RequestDeviceError(
session->thread_id, session->request_id,
- WebBluetoothError::CHOOSER_DENIED_PERMISSION));
+ WebBluetoothError::CHOOSER_NOT_SHOWN_USER_DENIED_PERMISSION_TO_SCAN));
request_device_sessions_.Remove(chooser_id);
return;
}
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | content/browser/bluetooth/bluetooth_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698