Add a kill switch for all of Web Bluetooth.

third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/bluetooth/BluetoothError.h"
 
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 
 namespace blink {
@@ skipping 30 matching lines @@
         MAP_ERROR(ConnectWriteNotPermitted, NetworkError, "GATT write operation is not permitted.");
         MAP_ERROR(DeviceNoLongerInRange, NetworkError, "Bluetooth Device is no longer in range.");
         MAP_ERROR(GATTNotPaired, NetworkError, "GATT Error: Not paired.");
         MAP_ERROR(GATTOperationInProgress, NetworkError, "GATT operation already in progress.");
         MAP_ERROR(UntranslatedConnectErrorCode, NetworkError, "Unknown ConnectErrorCode.");
 
         // NotFoundErrors:
         MAP_ERROR(NoBluetoothAdapter, NotFoundError, "Bluetooth adapter not available.");
         MAP_ERROR(ChosenDeviceVanished, NotFoundError, "User selected a device that doesn't exist anymore.");
         MAP_ERROR(ChooserCancelled, NotFoundError, "User cancelled the requestDevice() chooser.");
-        MAP_ERROR(ChooserDisabled, NotFoundError, "User or their enterprise policy has disabled Web Bluetooth globally.");
-        MAP_ERROR(ChooserDeniedPermission, NotFoundError, "User denied the browser permission to scan for Bluetooth devices.");
+        MAP_ERROR(ChooserNotShown_APIGloballyDisabled, NotFoundError, "Web Bluetooth API globally disabled.");
+        MAP_ERROR(ChooserNotShown_APILocallyDisabled, NotFoundError, "User or their enterprise policy has disabled Web Bluetooth.");
+        MAP_ERROR(ChooserNotShown_BrowserDeniedPermissionToScan, NotFoundError, "User denied the browser permission to scan for Bluetooth devices.");

[ortuno, 2016/03/30 19:19:46]

We have errors where we don't show the chooser i.e. when we can't ask for
permissions but we also have errors where we do show the chooser but the user
decided not to enable the permission.

[Jeffrey Yasskin, 2016/03/30 19:31:24]

Yeah, there's a chance this one did show the chooser, and that's when the user
decided never to let Chrome ask again. Do you have a better idea for the enum
value? It's a separate error message because the website needs to know that
calling requestDevice() either had or is going to have no effect, so the user's
going to think something's broken.

[ortuno, 2016/03/30 19:41:51]

"UserDeniedPermissionToScan"?

[Jeffrey Yasskin, 2016/03/30 23:11:40]

Sure, done.

         MAP_ERROR(ServiceNotFound, NotFoundError, "Service not found in device.");
         MAP_ERROR(CharacteristicNotFound, NotFoundError, "No Characteristics with specified UUID found in Service.");
         MAP_ERROR(NoCharacteristicsFound, NotFoundError, "No Characteristics found in service.");
 
         // NotSupportedErrors:
         MAP_ERROR(GATTUnknownError, NotSupportedError, "GATT Error Unknown.");
         MAP_ERROR(GATTUnknownFailure, NotSupportedError, "GATT operation failed for unknown reason.");
         MAP_ERROR(GATTNotPermitted, NotSupportedError, "GATT operation not permitted.");
         MAP_ERROR(GATTNotSupported, NotSupportedError, "GATT Error: Not supported.");
         MAP_ERROR(GATTUntranslatedErrorCode, NotSupportedError, "GATT Error: Unknown GattErrorCode.");
 
         // SecurityErrors:
         MAP_ERROR(GATTNotAuthorized, SecurityError, "GATT operation not authorized.");
         MAP_ERROR(BlacklistedCharacteristicUUID, SecurityError, "getCharacteristic(s) called with blacklisted UUID. https://goo.gl/4NeimX");
         MAP_ERROR(BlacklistedRead, SecurityError, "readValue() called on blacklisted object marked exclude-reads. https://goo.gl/4NeimX");
         MAP_ERROR(BlacklistedWrite, SecurityError, "writeValue() called on blacklisted object marked exclude-writes. https://goo.gl/4NeimX");
         MAP_ERROR(NotAllowedToAccessService, SecurityError, "Origin is not allowed to access the service. Remember to add the service to a filter or to optionalServices in requestDevice().");
         MAP_ERROR(RequestDeviceWithBlacklistedUUID, SecurityError, "requestDevice() called with a filter containing a blacklisted UUID. https://goo.gl/4NeimX");
         MAP_ERROR(RequestDeviceWithUniqueOrigin, SecurityError, "requestDevice() called from sandboxed or otherwise unique origin.");
         MAP_ERROR(RequestDeviceWithoutFrame, SecurityError, "No window to show the requestDevice() dialog.");
 
 #undef MAP_ERROR
     }
 
     ASSERT_NOT_REACHED();
     return DOMException::create(UnknownError);
 }
 
 } // namespace blink