Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 1841733002: [arm] Correctly detect ARMv8 platforms with old kernels. (Closed)

Created:
4 years, 8 months ago by jbramley
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Correctly detect ARMv8 platforms with old kernels. AArch64 kernels older than 3.18 presented a different cpuinfo format than what V8 expects. Most of V8's logic still works, but it misreads the "CPU architecture" field. BUG= Committed: https://crrev.com/4ee76dafc00c27989a3ee1389bc4cdaa728139a9 Cr-Commit-Position: refs/heads/master@{#35114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/base/cpu.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 8 months ago (2016-03-29 15:51:08 UTC) #2
Benedikt Meurer
Nice. LGTM.
4 years, 8 months ago (2016-03-29 17:04:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841733002/1
4 years, 8 months ago (2016-03-29 17:05:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 17:34:48 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:36:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ee76dafc00c27989a3ee1389bc4cdaa728139a9
Cr-Commit-Position: refs/heads/master@{#35114}

Powered by Google App Engine
This is Rietveld 408576698