Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1841713002: [elements] move MoveElements to abstract superclass (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] move MoveElements to abstract superclass BUG= Committed: https://crrev.com/0c8f54fdd3a3b5cb5dca5bd644f06ce6e465f09f Cr-Commit-Position: refs/heads/master@{#35109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -55 lines) Patch
M src/elements.cc View 4 chunks +30 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 8 months ago (2016-03-29 13:33:44 UTC) #2
Toon Verwaest
lgtm
4 years, 8 months ago (2016-03-29 13:55:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841713002/1
4 years, 8 months ago (2016-03-29 14:06:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 14:53:56 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 14:54:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0c8f54fdd3a3b5cb5dca5bd644f06ce6e465f09f
Cr-Commit-Position: refs/heads/master@{#35109}

Powered by Google App Engine
This is Rietveld 408576698