Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1841673003: Store PaintLayerFilterInfo in PaintLayerRareData instead of a HashMap. (Closed)

Created:
4 years, 8 months ago by esprehn
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store PaintLayerFilterInfo in PaintLayerRareData instead of a HashMap. This matches what we do for PaintLayerReflectionInfo and is much simpler. Committed: https://crrev.com/97cdb63f931be0e1aa2391f8a9aff6a68b5c9271 Cr-Commit-Position: refs/heads/master@{#383936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -101 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 4 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.h View 4 chunks +3 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerFilterInfo.cpp View 1 chunk +1 line, -48 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841673003/1
4 years, 8 months ago (2016-03-29 22:30:29 UTC) #2
esprehn
4 years, 8 months ago (2016-03-30 00:31:36 UTC) #4
pdr.
On 2016/03/30 at 00:31:36, esprehn wrote: > LGTM, this is much much simpler. Possibly the ...
4 years, 8 months ago (2016-03-30 00:46:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841673003/1
4 years, 8 months ago (2016-03-30 00:54:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841673003/1
4 years, 8 months ago (2016-03-30 06:50:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841673003/1
4 years, 8 months ago (2016-03-30 06:51:40 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/195962)
4 years, 8 months ago (2016-03-30 07:49:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841673003/1
4 years, 8 months ago (2016-03-30 08:14:04 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 09:17:50 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 09:19:56 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97cdb63f931be0e1aa2391f8a9aff6a68b5c9271
Cr-Commit-Position: refs/heads/master@{#383936}

Powered by Google App Engine
This is Rietveld 408576698