components/autofill/content/renderer/password_form_conversion_utils.cc - Issue 1841663002: Trim username_value to passwordForm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 1841663002: Trim username_value to passwordForm Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/content/renderer/password_form_conversion_utils.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc

index afecbcbac0a5ffec7471cc22e55d4ff0344317e9..f9f8aad1941ec9d3ad8b9a1fe855f43604941c1d 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc

@@ -546,6 +546,7 @@ bool GetPasswordForm(const SyntheticForm& form,

}

+ base::TrimString(username_value, base::ASCIIToUTF16(" "), &username_value);

ramya.v 2016/03/31 04:10:07 Can you add a test in password_form_conversion_uti

password_form->username_value = username_value;

}

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »