Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 1841663002: Trim username_value to passwordForm

Created:
4 years, 8 months ago by yeonju.ann
Modified:
4 years, 8 months ago
Reviewers:
ramya.v
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlistautofill_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim username_value to passwordForm username_element having input type="text" allows space character and it can make duplicated suggestion items to users. One is a normal id and the other is the id including space character. Usually when user input id with predictive text of IME, it include space character at the end. So need trim username_value. BUG=598543

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
ramya.v
https://codereview.chromium.org/1841663002/diff/20001/components/autofill/content/renderer/password_form_conversion_utils.cc File components/autofill/content/renderer/password_form_conversion_utils.cc (right): https://codereview.chromium.org/1841663002/diff/20001/components/autofill/content/renderer/password_form_conversion_utils.cc#newcode549 components/autofill/content/renderer/password_form_conversion_utils.cc:549: base::TrimString(username_value, base::ASCIIToUTF16(" "), &username_value); Can you add a test ...
4 years, 8 months ago (2016-03-31 04:10:07 UTC) #3
vabr (Chromium)
4 years, 8 months ago (2016-03-31 09:26:16 UTC) #4
Hello,

Thanks for the contribution, but please note that this is a somewhat
controversial change: http://crbug.com/598543#c5.

Cheers,
Vaclav

Powered by Google App Engine
This is Rietveld 408576698