ios/web/navigation/navigation_item_impl.h - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/navigation_item_impl.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/navigation/navigation_item_impl.h

diff --git a/ios/web/navigation/navigation_item_impl.h b/ios/web/navigation/navigation_item_impl.h

index f412db3751ce9b1a2e5aa7df4de920f24744b2a7..8462cbd671b0a4c0f33c2f198df10481e696a008 100644

--- a/ios/web/navigation/navigation_item_impl.h

+++ b/ios/web/navigation/navigation_item_impl.h

@@ -51,8 +51,7 @@ class NavigationItemImpl : public web::NavigationItem {

const base::string16& GetTitle() const override;

void SetPageDisplayState(const PageDisplayState& display_state) override;

const PageDisplayState& GetPageDisplayState() const override;

- const base::string16& GetTitleForDisplay(

- const std::string& languages) const override;

+ const base::string16& GetTitleForDisplay() const override;

void SetTransitionType(ui::PageTransition transition_type) override;

ui::PageTransition GetTransitionType() const override;

const FaviconStatus& GetFavicon() const override;

« no previous file with comments | « ios/chrome/browser/ui/webui/history/browsing_history_handler.cc ('k') | ios/web/navigation/navigation_item_impl.mm » ('j') | no next file with comments »