components/bookmarks/test/test_bookmark_client.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/test/test_bookmark_client.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc ('k') | components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/test/test_bookmark_client.cc

diff --git a/components/bookmarks/test/test_bookmark_client.cc b/components/bookmarks/test/test_bookmark_client.cc

index a4fddc2f3d74d5c8aebc5d37702dadbefa926cf6..1b22ab25767ec5bed988c8e9b30c50f0d996d00b 100644

--- a/components/bookmarks/test/test_bookmark_client.cc

+++ b/components/bookmarks/test/test_bookmark_client.cc

@@ -30,8 +30,7 @@ scoped_ptr<BookmarkModel> TestBookmarkClient::CreateModelWithClient(

scoped_ptr<BookmarkClient> client) {

scoped_ptr<BookmarkModel> bookmark_model(

new BookmarkModel(std::move(client)));

- scoped_ptr<BookmarkLoadDetails> details =

- bookmark_model->CreateLoadDetails(std::string());

+ scoped_ptr<BookmarkLoadDetails> details = bookmark_model->CreateLoadDetails();

details->LoadExtraNodes();

bookmark_model->DoneLoading(std::move(details));

return bookmark_model;