components/bookmarks/browser/bookmark_index.h - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_index.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo in elide_url.cc Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc ('k') | components/bookmarks/browser/bookmark_index.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_index.h

diff --git a/components/bookmarks/browser/bookmark_index.h b/components/bookmarks/browser/bookmark_index.h

index 7b17bceb1d87edf198d863e86eab3bfd391d34f3..a5f9bbfe519f34af426e0c4fc0cd545d025b475d 100644

--- a/components/bookmarks/browser/bookmark_index.h

+++ b/components/bookmarks/browser/bookmark_index.h

@@ -31,9 +31,7 @@ struct BookmarkMatch;

// BookmarkNodes that contain that string in their title or URL.

class BookmarkIndex {

public:

- // |languages| is used to help parse IDNs in URLs for the bookmark index.

- BookmarkIndex(BookmarkClient* client,

- const std::string& languages);

+ BookmarkIndex(BookmarkClient* client);

~BookmarkIndex();

// Invoked when a bookmark has been added to the model.

@@ -88,9 +86,6 @@ class BookmarkIndex {

BookmarkClient* const client_;

- // Languages used to help parse IDNs in URLs for the bookmark index.

- const std::string languages_;

DISALLOW_COPY_AND_ASSIGN(BookmarkIndex);

};