extensions/browser/guest_view/web_view/javascript_dialog_helper.h - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, most Android targets locally built successfully Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/url_formatter/elide_url.cc ('K') | « content/shell/browser/shell_javascript_dialog_manager.cc ('k') | extensions/browser/guest_view/web_view/javascript_dialog_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.h

diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.h b/extensions/browser/guest_view/web_view/javascript_dialog_helper.h

index 1d40fb2352404a3ecde8e0d1d722a04825c39736..2be5bbbc4d18987e9aa8c39f7b148b7a6e76c503 100644

--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.h

+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.h

@@ -21,7 +21,6 @@ class JavaScriptDialogHelper : public content::JavaScriptDialogManager {

void RunJavaScriptDialog(

content::WebContents* web_contents,

const GURL& origin_url,

- const std::string& accept_lang,

content::JavaScriptMessageType javascript_message_type,

const base::string16& message_text,

const base::string16& default_prompt_text,