content/public/browser/navigation_entry.h - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_entry.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, most Android targets locally built successfully Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/url_formatter/elide_url.cc ('K') | « content/public/browser/javascript_dialog_manager.h ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/navigation_entry.h

diff --git a/content/public/browser/navigation_entry.h b/content/public/browser/navigation_entry.h

index 008b151631aa2793eea1c337e9884b26771db674..5041cbecd9da986464da06032c6685e15d10a61c 100644

--- a/content/public/browser/navigation_entry.h

+++ b/content/public/browser/navigation_entry.h

@@ -109,11 +109,8 @@ class NavigationEntry {

// Page-related helpers ------------------------------------------------------

// Returns the title to be displayed on the tab. This could be the title of

- // the page if it is available or the URL. |languages| is the list of

- // accepted languages (e.g., prefs::kAcceptLanguages) or empty if proper

- // URL formatting isn't needed (e.g., unit tests).

- virtual const base::string16& GetTitleForDisplay(

- const std::string& languages) const = 0;

+ // the page if it is available or the URL.

+ virtual const base::string16& GetTitleForDisplay() const = 0;

// Returns true if the current tab is in view source mode. This will be false

// if there is no navigation.

« components/url_formatter/elide_url.cc ('K') | « content/public/browser/javascript_dialog_manager.h ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »