components/security_interstitials/core/common_string_util.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/common_string_util.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, most Android targets locally built successfully Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/search_engines/template_url.cc ('K') | « components/security_interstitials/core/common_string_util.h ('k') | components/security_interstitials/core/ssl_error_ui.h » ('j') | components/url_formatter/elide_url.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/common_string_util.cc

diff --git a/components/security_interstitials/core/common_string_util.cc b/components/security_interstitials/core/common_string_util.cc

index 1f9bd444e9414f28975e3bb9236b704819ffc053..2cb0375d0d08e0a84ffcd08f0631a353f08a6d67 100644

--- a/components/security_interstitials/core/common_string_util.cc

+++ b/components/security_interstitials/core/common_string_util.cc

@@ -16,9 +16,8 @@ namespace security_interstitials {

namespace common_string_util {

-base::string16 GetFormattedHostName(const GURL& gurl,

- const std::string& languages) {

- base::string16 host = url_formatter::IDNToUnicode(gurl.host(), languages);

+base::string16 GetFormattedHostName(const GURL& gurl) {

+ base::string16 host = url_formatter::IDNToUnicode(gurl.host());

if (base::i18n::IsRTL())

base::i18n::WrapStringWithLTRFormatting(&host);

return host;