components/password_manager/core/browser/affiliation_utils.h - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/affiliation_utils.h

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, most Android targets locally built successfully Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/omnibox/browser/in_memory_url_index.cc ('K') | « components/omnibox/browser/zero_suggest_provider.cc ('k') | components/password_manager/core/browser/affiliation_utils.cc » ('j') | components/search_engines/template_url.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/affiliation_utils.h

diff --git a/components/password_manager/core/browser/affiliation_utils.h b/components/password_manager/core/browser/affiliation_utils.h

index 1bc5767bb7055dbb51380c09861632857f0aa3cb..fcf8b7e905410cd4232c519b7e608bead3e46967 100644

--- a/components/password_manager/core/browser/affiliation_utils.h

+++ b/components/password_manager/core/browser/affiliation_utils.h

@@ -181,11 +181,8 @@ bool AreEquivalenceClassesEqual(const AffiliatedFacets& a,

bool IsValidAndroidFacetURI(const std::string& uri);

// Returns the origin URI in a format which can be presented to a user based of

-// |password_from| field values. For web URIs |languages| is using in order to

-// determine whether a URI is 'comprehensible' to a user who understands

-// languages listed.

-std::string GetHumanReadableOrigin(const autofill::PasswordForm& password_form,

- const std::string& languages);

+// |password_from| field values.

+std::string GetHumanReadableOrigin(const autofill::PasswordForm& password_form);

// Returns the Android origin URI for presenting to a user.

std::string GetHumanReadableOriginForAndroidUri(const FacetURI facet_uri);