components/omnibox/browser/shortcuts_backend_unittest.cc - Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/shortcuts_backend_unittest.cc

Issue 1841653003: Drop |languages| from {Format,Elide}Url* and IDNToUnicode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, most Android targets locally built successfully Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/omnibox/browser/in_memory_url_index.cc ('K') | « components/omnibox/browser/search_suggestion_parser.cc ('k') | components/omnibox/browser/shortcuts_provider.h » ('j') | components/search_engines/template_url.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/shortcuts_backend_unittest.cc

diff --git a/components/omnibox/browser/shortcuts_backend_unittest.cc b/components/omnibox/browser/shortcuts_backend_unittest.cc

index 03407b408c1698c29a174d5563bc7781ca2e13f1..31b59d97b719e8e84f07bff265a39f5b4be9324b 100644

--- a/components/omnibox/browser/shortcuts_backend_unittest.cc

+++ b/components/omnibox/browser/shortcuts_backend_unittest.cc

@@ -110,10 +110,8 @@ void ShortcutsBackendTest::SetSearchProvider() {

void ShortcutsBackendTest::SetUp() {

template_url_service_.reset(new TemplateURLService(nullptr, 0));

- if (profile_dir_.CreateUniqueTempDir()) {

- history_service_ =

- history::CreateHistoryService(profile_dir_.path(), std::string(), true);

- }

+ if (profile_dir_.CreateUniqueTempDir())

+ history_service_ = history::CreateHistoryService(profile_dir_.path(), true);

ASSERT_TRUE(history_service_);

db_thread_.Start();