Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1841643004: paintInvalidationContainerSkipped/containerSkipped => ancestorSkipped (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

paintInvalidationContainerSkipped/containerSkipped => ancestorSkipped These were overlooked in the previous CL which renamed paintInvalidationContainer to ancestor in some places that the parameter is not necessary a paintInvalidtionContainer. Committed: https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682 Cr-Commit-Position: refs/heads/master@{#383920}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Also update some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 9 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Xianzhu
4 years, 8 months ago (2016-03-29 23:18:33 UTC) #2
chrishtr
lgtm
4 years, 8 months ago (2016-03-29 23:20:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841643004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841643004/1
4 years, 8 months ago (2016-03-29 23:21:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841643004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841643004/20001
4 years, 8 months ago (2016-03-29 23:24:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841643004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841643004/40001
4 years, 8 months ago (2016-03-29 23:27:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/195876)
4 years, 8 months ago (2016-03-30 05:55:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841643004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841643004/40001
4 years, 8 months ago (2016-03-30 05:56:25 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 07:26:23 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 07:27:52 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5669551078f1bb3ef1e56d2e7cc64bc2164ce682
Cr-Commit-Position: refs/heads/master@{#383920}

Powered by Google App Engine
This is Rietveld 408576698