Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1841643003: Remove unused fields from WebGraphicsContext3D::Attributes. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
CC:
chrishtr, bajones, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, jbauman+watch_chromium.org, Justin Novosad, kalyank, Ken Russell (switch to Gerrit), piman+watch_chromium.org, piman, sievers+watch_chromium.org, no sievers, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused fields from WebGraphicsContext3D::Attributes. The webGL field was used but it is redundant with webGLVersion which will be non-zero when webGL was true. R=chrishtr@chromium.org, kbr@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/5d65a9ab045330320037ae1efc55be335aa1cabb Cr-Commit-Position: refs/heads/master@{#384077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebGraphicsContext3D.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
danakj
4 years, 8 months ago (2016-03-29 22:54:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841643003/1
4 years, 8 months ago (2016-03-29 22:55:17 UTC) #4
chrishtr
lgtm
4 years, 8 months ago (2016-03-29 22:56:10 UTC) #5
danakj
oh +piman for content/
4 years, 8 months ago (2016-03-29 23:08:52 UTC) #7
Ken Russell (switch to Gerrit)
lgtm
4 years, 8 months ago (2016-03-30 01:41:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841643003/1
4 years, 8 months ago (2016-03-30 01:52:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/195849)
4 years, 8 months ago (2016-03-30 05:27:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841643003/1
4 years, 8 months ago (2016-03-30 18:51:08 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 20:23:07 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:24:58 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d65a9ab045330320037ae1efc55be335aa1cabb
Cr-Commit-Position: refs/heads/master@{#384077}

Powered by Google App Engine
This is Rietveld 408576698