fpdfsdk/javascript/Field.cpp - Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/Field.cpp

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/Field.cpp

diff --git a/fpdfsdk/javascript/Field.cpp b/fpdfsdk/javascript/Field.cpp

index 54b4f6432c9e230d93b9bdf8ac56807ba9aca3c9..5b8750d88e7907bb08dc6984ea1242ddfb45fa27 100644

--- a/fpdfsdk/javascript/Field.cpp

+++ b/fpdfsdk/javascript/Field.cpp

@@ -1014,7 +1014,7 @@ void Field::SetCurrentValueIndices(CPDFSDK_Document* pDocument,

for (size_t i = 0; i < array.size(); ++i) {

if (i != 0 && !(dwFieldFlags & (1 << 21)))

break;

- if (array[i] < pFormField->CountOptions() &&

+ if (array[i] < static_cast<uint32_t>(pFormField->CountOptions()) &&

!pFormField->IsItemSelected(array[i])) {

pFormField->SetItemSelection(array[i], TRUE);

}

« no previous file with comments | « fpdfsdk/fpdfview_embeddertest.cpp ('k') | fpdfsdk/javascript/PublicMethods.cpp » ('j') | no next file with comments »