core/fxcrt/fx_basic_gcc_unittest.cpp - Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_gcc_unittest.cpp

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic_gcc_unittest.cpp

diff --git a/core/fxcrt/fx_basic_gcc_unittest.cpp b/core/fxcrt/fx_basic_gcc_unittest.cpp

index 8d8d2f5deb6edd27de90872bc09d8056baf31b85..c6913cfd8205075d66fe51a82fd53dd69e94871c 100644

--- a/core/fxcrt/fx_basic_gcc_unittest.cpp

+++ b/core/fxcrt/fx_basic_gcc_unittest.cpp

@@ -93,16 +93,16 @@ TEST(fxcrt, FXSYS_wtoi64) {

}

TEST(fxcrt, FXSYS_atoui) {

- EXPECT_EQ(0, FXSYS_atoui(""));

- EXPECT_EQ(0, FXSYS_atoui("0"));

+ EXPECT_EQ(0u, FXSYS_atoui(""));

+ EXPECT_EQ(0u, FXSYS_atoui("0"));

EXPECT_EQ(4294967295, FXSYS_atoui("-1"));

- EXPECT_EQ(2345, FXSYS_atoui("2345"));

+ EXPECT_EQ(2345u, FXSYS_atoui("2345"));

// Handle the sign.

EXPECT_EQ(4294964951, FXSYS_atoui("-2345"));

- EXPECT_EQ(2345, FXSYS_atoui("+2345"));

+ EXPECT_EQ(2345u, FXSYS_atoui("+2345"));

// The max value.

EXPECT_EQ(4294967295, FXSYS_atoui("4294967295"));

- EXPECT_EQ(9, FXSYS_atoui("9x9"));

+ EXPECT_EQ(9u, FXSYS_atoui("9x9"));

// Out of range values.

EXPECT_EQ(4294967295, FXSYS_atoui("2147483623423412348"));

« no previous file with comments | « core/fxcodec/codec/fx_codec_jpx_unittest.cpp ('k') | core/fxcrt/include/fx_string.h » ('j') | no next file with comments »