core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp - Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Issue 1841643002: Code change to avoid signed/unsigned mismatch warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: change comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

index 7dc90601c418bc17db35c497e7f5f56df113d982..7727cc0ec72a3a8edaa1d9572f3ab7dce56f18f8 100644

--- a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

@@ -1410,7 +1410,7 @@ void CPDF_Creator::InitNewObjNumOffsets() {

for (const auto& pair : m_pDocument->m_IndirectObjs) {

const uint32_t objnum = pair.first;

const CPDF_Object* pObj = pair.second;

- if (pObj->GetObjNum() == -1)

+ if (pObj->GetObjNum() == CPDF_Object::kInvalidObjNum)

continue;

if (bIncremental) {

if (!pObj->IsModified())