Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1841633002: Make constructors in Worklets be properly exposed on the global. (Closed)

Created:
4 years, 8 months ago by ikilpatrick
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make constructors in Worklets be properly exposed on the global. Add global listing test case for Worklets. BUG=567358 Committed: https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503 Cr-Commit-Position: refs/heads/master@{#383664}

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
ikilpatrick
4 years, 8 months ago (2016-03-29 00:16:51 UTC) #3
haraken
Why do you need to change gni/gyp to make changes on global listing?
4 years, 8 months ago (2016-03-29 00:26:06 UTC) #4
ikilpatrick
On 2016/03/29 00:26:06, haraken wrote: > Why do you need to change gni/gyp to make ...
4 years, 8 months ago (2016-03-29 01:17:22 UTC) #6
haraken
On 2016/03/29 01:17:22, ikilpatrick wrote: > On 2016/03/29 00:26:06, haraken wrote: > > Why do ...
4 years, 8 months ago (2016-03-29 01:21:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841633002/1
4 years, 8 months ago (2016-03-29 03:38:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 03:43:17 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 03:44:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9279e2d0a23065e1b2f8f12a36843388cced503
Cr-Commit-Position: refs/heads/master@{#383664}

Powered by Google App Engine
This is Rietveld 408576698