Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1841613002: Add config for Chromium Mac 10.11 Force Mac Toolchain on chromium.fyi (Closed)

Created:
4 years, 8 months ago by smut
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add config for Chromium Mac 10.11 Force Mac Toolchain on chromium.fyi BUG=598393 Committed: https://crrev.com/b378313f791b5208e4f980f2e1d9e36a391b3107 Cr-Commit-Position: refs/heads/master@{#383821}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove isolated_scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
smut
Copy/pasted Chromium Mac 10.11. See also https://codereview.chromium.org/1836883003.
4 years, 8 months ago (2016-03-28 22:53:05 UTC) #2
Paweł Hajdan Jr.
LGTM w/comment (please fix) https://codereview.chromium.org/1841613002/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1841613002/diff/1/testing/buildbot/chromium.fyi.json#newcode900 testing/buildbot/chromium.fyi.json:900: "isolated_scripts": [ This is no-op ...
4 years, 8 months ago (2016-03-29 13:16:58 UTC) #4
smut
https://codereview.chromium.org/1841613002/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1841613002/diff/1/testing/buildbot/chromium.fyi.json#newcode900 testing/buildbot/chromium.fyi.json:900: "isolated_scripts": [ On 2016/03/29 13:16:58, Paweł Hajdan Jr. wrote: ...
4 years, 8 months ago (2016-03-29 19:54:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841613002/20001
4 years, 8 months ago (2016-03-29 19:55:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 21:04:07 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:05:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b378313f791b5208e4f980f2e1d9e36a391b3107
Cr-Commit-Position: refs/heads/master@{#383821}

Powered by Google App Engine
This is Rietveld 408576698