Chromium Code Reviews| Index: tools/rebaseline.py |
| =================================================================== |
| --- tools/rebaseline.py (revision 9956) |
| +++ tools/rebaseline.py (working copy) |
| @@ -188,11 +188,7 @@ |
| # Write out updated expectations. |
| gm_json.WriteToFile(expectations_dict, expectations_json_filepath) |
| - if skipped_images: |
| - print ('Skipped these tests due to test/config filters: %s' % |
|
epoger
2013/07/10 16:24:03
I deleted this output while I was at it... it seem
|
| - skipped_images) |
| - |
| # main... |
| parser = argparse.ArgumentParser() |
| @@ -275,6 +271,12 @@ |
| actuals_filename=args.actuals_filename, |
| add_new=args.add_new) |
| else: |
| + # TODO(epoger): When we get rid of the ImageRebaseliner implementation, |
| + # we should raise an Exception in this case (no JSON expectations file |
| + # found to update), to prevent a recurrence of |
| + # https://code.google.com/p/skia/issues/detail?id=1403 ('rebaseline.py |
| + # script fails with misleading output when run outside of gm-expected |
| + # dir') |
| rebaseliner = rebaseline_imagefiles.ImageRebaseliner( |
| expectations_root=args.expectations_root, |
| tests=args.tests, configs=args.configs, |