ARC Toast: Prevent onClosed event from being called multiple times

ash/system/toast/toast_overlay.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/toast/toast_overlay.h"
 
 #include "ash/screen_util.h"
 #include "ash/shelf/shelf.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
@@ skipping 179 matching lines @@
 
   gfx::NativeWindow native_view = overlay_widget_->GetNativeView();
   wm::SetWindowVisibilityAnimationType(
       native_view, wm::WINDOW_VISIBILITY_ANIMATION_TYPE_VERTICAL);
   wm::SetWindowVisibilityAnimationDuration(
       native_view,
       base::TimeDelta::FromMilliseconds(kSlideAnimationDurationMs));
 }
 
 ToastOverlay::~ToastOverlay() {
-  gfx::NativeWindow native_view = overlay_widget_->GetNativeView();
-  wm::SetWindowVisibilityAnimationTransition(native_view, wm::ANIMATE_NONE);
-
-  // Remove ourself from the animator to avoid being re-entrantly called in
-  // |overlay_widget_|'s destructor.
-  ui::Layer* layer = overlay_widget_->GetLayer();
-  if (layer) {
-    ui::LayerAnimator* animator = layer->GetAnimator();
-    if (animator)
-      animator->RemoveObserver(this);
-  }
-
   overlay_widget_->Close();
 }
 
 void ToastOverlay::Show(bool visible) {
-  if (is_visible_ == visible)
+  if (overlay_widget_->GetLayer()->GetTargetVisibility() == visible)
     return;
 
-  is_visible_ = visible;
+  ui::LayerAnimator* animator = overlay_widget_->GetLayer()->GetAnimator();
+  DCHECK(animator);
 
-  overlay_widget_->GetLayer()->GetAnimator()->AddObserver(this);
+  base::TimeDelta original_duration = animator->GetTransitionDuration();
+  ui::ScopedLayerAnimationSettings animation_settings(animator);
+  // ScopedLayerAnimationSettings ctor chanes the transition duration, so change
+  // back it to the original value (should be zero).
+  animation_settings.SetTransitionDuration(original_duration);
 
-  if (is_visible_)
+  animation_settings.AddObserver(this);
+
+  if (visible)
     overlay_widget_->Show();
   else
     overlay_widget_->Hide();
 }
 
 gfx::Rect ToastOverlay::CalculateOverlayBounds() {
   ShelfLayoutManager* shelf_layout_manager =
       Shelf::ForPrimaryDisplay()->shelf_layout_manager();
   gfx::Rect work_area_bounds = shelf_layout_manager->user_work_area_bounds();
 
   gfx::Rect bounds = shelf_layout_manager->user_work_area_bounds();
   int target_y = bounds.bottom() - widget_size_.height() - kVerticalOffset;
   bounds.ClampToCenteredSize(widget_size_);
   bounds.set_y(target_y);
   return bounds;
 }
 
-void ToastOverlay::OnLayerAnimationEnded(ui::LayerAnimationSequence* sequence) {
-  ui::LayerAnimator* animator = overlay_widget_->GetLayer()->GetAnimator();
-  if (animator)
-    animator->RemoveObserver(this);
-  if (!is_visible_) {
-    // Acync operation, since delegate may remove this instance and removing
-    // this here causes crash.
-    base::ThreadTaskRunnerHandle::Get()->PostTask(
-        FROM_HERE,
-        base::Bind(&Delegate::OnClosed,
-                   base::Unretained(delegate_) /* |delegate| lives longer */));
-  }
+void ToastOverlay::OnImplicitAnimationsScheduled() {}
+
+void ToastOverlay::OnImplicitAnimationsCompleted() {
+  if (!overlay_widget_->GetLayer()->GetTargetVisibility())
+    delegate_->OnClosed();
 }
 
-void ToastOverlay::OnLayerAnimationAborted(
-    ui::LayerAnimationSequence* sequence) {
-  ui::LayerAnimator* animator = overlay_widget_->GetLayer()->GetAnimator();
-  if (animator)
-    animator->RemoveObserver(this);
-}
-
-void ToastOverlay::OnLayerAnimationScheduled(
-    ui::LayerAnimationSequence* sequence) {}
-
 views::Widget* ToastOverlay::widget_for_testing() {
   return overlay_widget_.get();
 }
 
 void ToastOverlay::ClickDismissButtonForTesting(const ui::Event& event) {
   overlay_view_->button()->NotifyClick(event);
 }
 
 }  // namespace ash