Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1841523003: Fix a corner case of constant evaluation cycle detection. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a corner case of constant evaluation cycle detection. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8835741088ab38f4c9c049082f37fced9faff5df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A tests/language/const_redirect_skips_supertype_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 8 months ago (2016-03-28 21:25:32 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-03-28 21:28:24 UTC) #3
Paul Berry
4 years, 8 months ago (2016-03-29 01:50:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8835741088ab38f4c9c049082f37fced9faff5df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698