extensions/browser/api/hid/hid_api.cc - Issue 1841483002: [Extensions] Convert APIs to use movable types [11]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_api.cc

Issue 1841483002: [Extensions] Convert APIs to use movable types [11] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/display_source/display_source_connection_delegate.h ('k') | extensions/browser/api/hid/hid_device_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/hid/hid_api.cc

diff --git a/extensions/browser/api/hid/hid_api.cc b/extensions/browser/api/hid/hid_api.cc

index 77972ea61abbabf1d6e6cf21fd12a0b59b380e50..841795db2c4004898bb9eeb55b6a3e85cbd11cbc 100644

--- a/extensions/browser/api/hid/hid_api.cc

+++ b/extensions/browser/api/hid/hid_api.cc

@@ -63,19 +63,19 @@ base::Value* PopulateHidConnection(int connection_id,

return connection_value.ToValue().release();

}

-void ConvertHidDeviceFilter(linked_ptr<hid::DeviceFilter> input,

+void ConvertHidDeviceFilter(const hid::DeviceFilter& input,

HidDeviceFilter* output) {

- if (input->vendor_id) {

- output->SetVendorId(*input->vendor_id);

+ if (input.vendor_id) {

+ output->SetVendorId(*input.vendor_id);

}

- if (input->product_id) {

- output->SetProductId(*input->product_id);

+ if (input.product_id) {

+ output->SetProductId(*input.product_id);

}

- if (input->usage_page) {

- output->SetUsagePage(*input->usage_page);

+ if (input.usage_page) {

+ output->SetUsagePage(*input.usage_page);

}

- if (input->usage) {

- output->SetUsage(*input->usage);

+ if (input.usage) {

+ output->SetUsage(*input.usage);

}