Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1841433003: Increase AST cache size to improve performance for large projects (Closed)

Created:
4 years, 8 months ago by skybrian
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Increase AST cache size to improve performance for large projects In the test I tried using dartanalyzer, it reduces the execution time from 170 seconds to 102 seconds. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2a41dc67346c63ea8ca545ce596b6477fa0aab2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
skybrian
4 years, 8 months ago (2016-03-28 20:49:29 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-03-28 20:52:13 UTC) #3
skybrian
4 years, 8 months ago (2016-03-28 20:53:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a41dc67346c63ea8ca545ce596b6477fa0aab2e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698