Issue 1841433002: Fix summary handling of enum values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1841433002: Fix summary handling of enum values. (Closed)

Created:
4 years, 8 months ago by Paul Berry

Modified:
4 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix summary handling of enum values. This CL fixes: - Computation of the public namespace when there are enums (previously we weren't including enum values in the public namespace). - Prelinking of references to enum values from constants. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ca47517be8c58973daadb1c6c9b7b8ee4f0273de

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -15 lines)			Patch
M	pkg/analyzer/lib/src/summary/prelink.dart	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/public_namespace_computer.dart	View	1 chunk	+17 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	3 chunks	+14 lines, -12 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_common.dart	View	3 chunks	+96 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 8 months ago (2016-03-28 16:55:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ca47517be8c58973daadb1c6c9b7b8ee4f0273de (presubmit successful).