Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18414007: Remove unused WEBKIT_DEPRECATED thread (Closed)

Created:
7 years, 5 months ago by jamesr
Modified:
7 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, extensions-reviews_chromium.org, jar (doing other things), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix content_browsertests #

Patch Set 3 : use db thread for ThreadWatcherTests #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -267 lines) Patch
M chrome/browser/extensions/extension_service_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 2 12 chunks +37 lines, -39 lines 2 comments Download
M content/browser/browser_main_loop.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 chunks +1 line, -31 lines 0 comments Download
M content/browser/browser_thread_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_thread_impl.cc View 1 2 3 3 chunks +0 lines, -10 lines 0 comments Download
D content/browser/in_process_webkit/webkit_thread.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/browser/in_process_webkit/webkit_thread.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D content/browser/in_process_webkit/webkit_thread_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/browser_thread.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/test/test_browser_thread_bundle.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/test/test_browser_thread_bundle.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
OK! I think everything that was depending on this is removed now, although it needs ...
7 years, 5 months ago (2013-07-19 04:48:00 UTC) #1
jam
lgtm woohoo!! https://codereview.chromium.org/18414007/diff/15001/chrome/browser/metrics/thread_watcher_unittest.cc File chrome/browser/metrics/thread_watcher_unittest.cc (right): https://codereview.chromium.org/18414007/diff/15001/chrome/browser/metrics/thread_watcher_unittest.cc#newcode279 chrome/browser/metrics/thread_watcher_unittest.cc:279: // Create thread watcher object for the ...
7 years, 5 months ago (2013-07-19 15:33:25 UTC) #2
scottmg
On 2013/07/19 04:48:00, jamesr wrote: > OK! I think everything that was depending on this ...
7 years, 5 months ago (2013-07-19 15:35:21 UTC) #3
jamesr
On 2013/07/19 15:33:25, jam wrote: > lgtm > woohoo!! > > https://codereview.chromium.org/18414007/diff/15001/chrome/browser/metrics/thread_watcher_unittest.cc > File chrome/browser/metrics/thread_watcher_unittest.cc ...
7 years, 5 months ago (2013-07-19 18:06:39 UTC) #4
jam
https://codereview.chromium.org/18414007/diff/15001/chrome/browser/metrics/thread_watcher_unittest.cc File chrome/browser/metrics/thread_watcher_unittest.cc (right): https://codereview.chromium.org/18414007/diff/15001/chrome/browser/metrics/thread_watcher_unittest.cc#newcode279 chrome/browser/metrics/thread_watcher_unittest.cc:279: // Create thread watcher object for the DB thread. ...
7 years, 5 months ago (2013-07-19 20:40:59 UTC) #5
jamesr
7 years, 5 months ago (2013-07-19 21:55:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 manually as r212661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698