third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp - Issue 1841363003: Replace RELEASE_ASSERT_WITH_SECURITY_IMPLICATION with SECURITY_CHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp

Issue 1841363003: Replace RELEASE_ASSERT_WITH_SECURITY_IMPLICATION with SECURITY_CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('k') | third_party/WebKit/Source/wtf/Assertions.h » ('j') | third_party/WebKit/Source/wtf/Assertions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp

index 15f24e6eebbb4cd634982982ec4baac4a316ed3a..19620d911463914ad7a7a11ae6a9b5996a8994a5 100644

--- a/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp

@@ -44,8 +44,7 @@ void BiquadDSPKernel::updateCoefficientsIfNecessary(int framesToProcess)

float gain[AudioUtilities::kRenderQuantumFrames];

float detune[AudioUtilities::kRenderQuantumFrames]; // in Cents

- RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(

- static_cast<unsigned>(framesToProcess) <= AudioUtilities::kRenderQuantumFrames);

+ SECURITY_CHECK(static_cast<unsigned>(framesToProcess) <= AudioUtilities::kRenderQuantumFrames);

if (getBiquadProcessor()->hasSampleAccurateValues()) {

getBiquadProcessor()->parameter1().calculateSampleAccurateValues(cutoffFrequency, framesToProcess);