third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h - Issue 1841353002: Implement ShadowRoot.mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

Issue 1841353002: Implement ShadowRoot.mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a comment and refactor the layout test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

index cf17ea363e54f0f07374f9bb32d0c8975b42d9c6..6633d33e9897149fa074453d1b79f473160b7d58 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h

@@ -79,6 +79,8 @@ public:

ShadowRoot* olderShadowRootForBindings() const;

+ String mode() const { return (type() == ShadowRootType::V0 || type() == ShadowRootType::Open) ? "open" : "closed"; };

bool isOpenOrV0() const { return type() == ShadowRootType::V0 || type() == ShadowRootType::Open; }

bool isV1() const { return type() == ShadowRootType::Open || type() == ShadowRootType::Closed; }