third_party/WebKit/LayoutTests/shadow-dom/shadowroot-mode.html - Issue 1841353002: Implement ShadowRoot.mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/shadow-dom/shadowroot-mode.html

Issue 1841353002: Implement ShadowRoot.mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <div id="log"></div>

	5 <div id = "host1"></div>

	6 <div id = "host2"></div>

	7 <div id = "host3"></div>
	kochi 2016/03/31 08:38:42 nit: Please be consistent on whitespaces around "= nit: Please be consistent on whitespaces around "=". yuzuchan 2016/03/31 09:32:25 Done. Show quoted text On 2016/03/31 at 08:38:42, kochi wrote: > nit: Please be consistent on whitespaces around "=". Done.
	8 <input id="input">

	9 <script>

	10

	11 test(function() {

	12 var host1 = document.getElementById('host1');
	kochi 2016/03/31 08:38:42 nit: it's okay to explicitly have this and followi nit: it's okay to explicitly have this and following lines, but HTML parser once parsed an element with id which doesn't conflict in the "window." namespace and doesn't have invalid character as a JS identifier, the variable is automatically created. So without line 12-15 this test should run. Just FYI - I personally think depending on this behavior in tests isn't a good practice, but this technique is often used in short layout tests. yuzuchan* 2016/03/31 09:32:25 Done. Show quoted text On 2016/03/31 at 08:38:42, kochi wrote: > nit: it's okay to explicitly have this and following lines, but HTML parser > once parsed an element with id which doesn't conflict in the "window.*" > namespace and doesn't have invalid character as a JS identifier, the variable > is automatically created. So without line 12-15 this test should run. > > Just FYI - I personally think depending on this behavior in tests isn't > a good practice, but this technique is often used in short layout tests. Done.
	13 var host2 = document.getElementById('host2');

	14 var host3 = document.getElementById('host3');

	15 var input = document.getElementById('input');

	16 host1.attachShadow({mode : 'open'});

	17 var closedShadowRoot = host2.attachShadow({mode : 'closed'});

	18 host3.createShadowRoot();

	19 assert_equals(host1.shadowRoot.mode, 'open');

	20 assert_equals(closedShadowRoot.mode, 'closed');

	21 assert_equals(host3.shadowRoot.mode, 'open');
	kochi 2016/03/31 08:38:42 Strictly speaking, mode for V0 shadow root and UA Strictly speaking, mode for V0 shadow root and UA shadow root is not (and will not be) specified anywhere. Could you add a comment here like: // Note: mode for V0 shadow and UA shadow is not specified anywhere, // Blink returns reasonable default values for these. yuzuchan 2016/03/31 09:32:25 Done. Show quoted text On 2016/03/31 at 08:38:42, kochi wrote: > Strictly speaking, mode for V0 shadow root and UA shadow root > is not (and will not be) specified anywhere. > > Could you add a comment here like: > // Note: mode for V0 shadow and UA shadow is not specified anywhere, > // Blink returns reasonable default values for these. Done.
	22 assert_equals(internals.shadowRoot(input).mode, 'closed');

	23 }, 'ShadowRoot.mode should return open or closed, and only open if v0.');

	24 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »