third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 1841333002: Various fixes for aria-activedescendant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 1841333002: Various fixes for aria-activedescendant. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated tests. Stopped firing a focus changed event when the active descendant changes. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index 40a4d970cac4c52a0b740cf64bed874698a4a979..550e311ec7c9edd43e6cdb5ce9a95957cadfc547 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -64,6 +64,7 @@ protected:

virtual AccessibilityRole nativeAccessibilityRoleIgnoringAria() const;

String accessibilityDescriptionForElements(WillBeHeapVector<RawPtrWillBeMember<Element>> &elements) const;

void alterSliderValue(bool increase);

+ AXObject* activeDescendant() const override;

String ariaAccessibilityDescription() const;

String ariaAutoComplete() const;

AccessibilityRole determineAriaRoleAttribute() const;

@@ -130,6 +131,7 @@ protected:

// Check whether certain properties can be modified.

bool canSetFocusAttribute() const override;

bool canSetValueAttribute() const override;

+ bool canSetSelectedAttribute() const override;

// Properties of static elements.

RGBA32 colorValue() const final;