third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp - Issue 1841333002: Various fixes for aria-activedescendant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

Issue 1841333002: Various fixes for aria-activedescendant. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added selectable and selected states to ARIA list box options. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXListBox.h ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.h » ('j') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

index 58b655b0bd5a51c641bf7acbdf7ae3c749748610..9294a961689a2e4b6f761e4ab43da17b048d8ba7 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

@@ -124,6 +124,9 @@ bool AXListBoxOption::computeAccessibilityIsIgnored(IgnoredReasons* ignoredReaso

bool AXListBoxOption::canSetSelectedAttribute() const

{

+ if (ancestorExposesActiveDescendant())

dmazzoni 2016/03/31 05:48:30 This shouldn't be before some of the other checks,

+ return true;

if (!isHTMLOptionElement(getNode()))

return false;