Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1841313004: Rename _CPDF_UniqueKeyGen to CPDF_UniqueKeyGen (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename _CPDF_UniqueKeyGen to CPDF_UniqueKeyGen Committed: https://pdfium.googlesource.com/pdfium/+/d734fd2f60c68a4cfa0e5bb8ff85d357605d3449

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 2 3 chunks +23 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_render/render_int.h View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-03-30 19:30:23 UTC) #2
Tom Sepez
https://codereview.chromium.org/1841313004/diff/1/core/fpdfapi/fpdf_render/render_int.h File core/fpdfapi/fpdf_render/render_int.h (right): https://codereview.chromium.org/1841313004/diff/1/core/fpdfapi/fpdf_render/render_int.h#newcode639 core/fpdfapi/fpdf_render/render_int.h:639: struct CPDF_UniqueKeyGen { can this move to the .cpp ...
4 years, 8 months ago (2016-03-30 19:55:30 UTC) #3
dsinclair
https://codereview.chromium.org/1841313004/diff/1/core/fpdfapi/fpdf_render/render_int.h File core/fpdfapi/fpdf_render/render_int.h (right): https://codereview.chromium.org/1841313004/diff/1/core/fpdfapi/fpdf_render/render_int.h#newcode639 core/fpdfapi/fpdf_render/render_int.h:639: struct CPDF_UniqueKeyGen { On 2016/03/30 19:55:30, Tom Sepez wrote: ...
4 years, 8 months ago (2016-03-30 20:01:23 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/1841313004/diff/20001/core/fpdfapi/fpdf_render/fpdf_render_text.cpp File core/fpdfapi/fpdf_render/fpdf_render_text.cpp (right): https://codereview.chromium.org/1841313004/diff/20001/core/fpdfapi/fpdf_render/fpdf_render_text.cpp#newcode200 core/fpdfapi/fpdf_render/fpdf_render_text.cpp:200: void CPDF_UniqueKeyGen::Generate(int count, ...) { Does this go ...
4 years, 8 months ago (2016-03-30 20:08:27 UTC) #5
dsinclair
https://codereview.chromium.org/1841313004/diff/20001/core/fpdfapi/fpdf_render/fpdf_render_text.cpp File core/fpdfapi/fpdf_render/fpdf_render_text.cpp (right): https://codereview.chromium.org/1841313004/diff/20001/core/fpdfapi/fpdf_render/fpdf_render_text.cpp#newcode200 core/fpdfapi/fpdf_render/fpdf_render_text.cpp:200: void CPDF_UniqueKeyGen::Generate(int count, ...) { On 2016/03/30 20:08:27, Tom ...
4 years, 8 months ago (2016-03-30 20:25:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841313004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841313004/40001
4 years, 8 months ago (2016-03-30 20:25:48 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:36:48 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/d734fd2f60c68a4cfa0e5bb8ff85d357605d...

Powered by Google App Engine
This is Rietveld 408576698