Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1841313003: Reject promise with InvalidStateError instead of null in createImageBitmap(Blob) (Closed)

Created:
4 years, 8 months ago by xidachen
Modified:
4 years, 8 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject promise with InvalidStateError instead of null in createImageBitmap(Blob) Right now, the createImageBitmap(Blob) reject promise with null when the input image cannot be decoded, for example, the input image is a SVG image. A recently change is made to the specs here: https://github.com/whatwg/html/pull/884 which states that we should reject the promise with InvalidStateError insetad of null. This CL changes it such that it will reject the promise with a InvalidStateError. BUG=596251 Committed: https://crrev.com/672ae7a2037e92b305054849f31a7bb4fb873823 Cr-Commit-Position: refs/heads/master@{#384045}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
xidachen
PTAL
4 years, 8 months ago (2016-03-30 15:32:28 UTC) #2
Justin Novosad
On 2016/03/30 15:32:28, xidachen wrote: > PTAL This is in response to a recent change ...
4 years, 8 months ago (2016-03-30 15:43:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841313003/1
4 years, 8 months ago (2016-03-30 15:47:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841313003/1
4 years, 8 months ago (2016-03-30 16:31:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 19:12:23 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 19:13:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/672ae7a2037e92b305054849f31a7bb4fb873823
Cr-Commit-Position: refs/heads/master@{#384045}

Powered by Google App Engine
This is Rietveld 408576698