[Cleanup] Factor out layout store code from DisplayController

[Cleanup] Factor out layout store code from DisplayController

TBR=jamescook@chromium.org
BUG=253991
TEST=no functional change. all tests should pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210706

[Jun Mukai, 2013-07-09 16:54:16]

lgtm with nits

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
ash/display/display_controller.cc:414: layout.primary_id = primary_display_id;
can't we move this setting primary_display_id logic to layout_store?
Not particularly sure, but intuitively it would be the task of the layout store.

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
File ash/display/display_controller.h (right):

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
ash/display/display_controller.h:12: #include "ash/display/display_layout.h"
display_layout.h include is not necessary anymore

[oshima, 2013-07-09 17:27:57]

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
ash/display/display_controller.cc:414: layout.primary_id = primary_display_id;
On 2013/07/09 16:54:17, Jun Mukai wrote:
> can't we move this setting primary_display_id logic to layout_store?
> Not particularly sure, but intuitively it would be the task of the layout
store.

store doesn't know about the current primary (only knows which is primary for
stored layout), so this needs to stay here.
(notice that this is fallback when default layout is requested
 with single display. I added NOTREACHED to make it clear)

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
File ash/display/display_controller.h (right):

https://codereview.chromium.org/18413002/diff/15001/ash/display/display_contr...
ash/display/display_controller.h:12: #include "ash/display/display_layout.h"
On 2013/07/09 16:54:17, Jun Mukai wrote:
> display_layout.h include is not necessary anymore

This is necessary for DisplayIdPair (which is typedef)
which is used in store, controller and manager.

It's possible to define separate header, or to make it a class
but either way sounds overkill to me.

[oshima, 2013-07-09 17:30:23]

tbr'ing for ash.gyp change

[commit-bot: I haz the power, 2013-07-09 17:31:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/18413002/24001

[commit-bot: I haz the power, 2013-07-10 01:43:30]

Change committed as 210706