Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1841273002: [chromecast] Fix build with enable_mojo_media=true. (Closed)

Created:
4 years, 8 months ago by alokp
Modified:
4 years, 8 months ago
Reviewers:
halliwell
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Fix build with enable_mojo_media=true. Committed: https://crrev.com/cb733f9fb4ec45a83696121e18d2c63bb32ffbba Cr-Commit-Position: refs/heads/master@{#383910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -47 lines) Patch
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/browser/media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/media/cast_mojo_media_client.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chromecast/browser/media/cast_mojo_media_client.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chromecast/browser/media/cast_renderer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chromecast/browser/media/cast_renderer.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M chromecast/browser/media/cma_message_filter_host.h View 3 chunks +3 lines, -8 lines 0 comments Download
M chromecast/browser/media/cma_message_filter_host.cc View 1 chunk +1 line, -1 line 0 comments Download
A chromecast/browser/media/media_pipeline_backend_factory.h View 1 chunk +22 lines, -0 lines 0 comments Download
M chromecast/browser/media/media_pipeline_host.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chromecast/browser/media/media_pipeline_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chromecast/media/cma/pipeline/media_pipeline_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alokp
4 years, 8 months ago (2016-03-29 22:59:19 UTC) #2
halliwell
On 2016/03/29 22:59:19, alokp wrote: lgtm
4 years, 8 months ago (2016-03-29 23:02:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841273002/1
4 years, 8 months ago (2016-03-29 23:17:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-03-30 01:19:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841273002/1
4 years, 8 months ago (2016-03-30 04:37:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 04:44:32 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 04:46:48 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cb733f9fb4ec45a83696121e18d2c63bb32ffbba
Cr-Commit-Position: refs/heads/master@{#383910}

Powered by Google App Engine
This is Rietveld 408576698