Fix most strong mode warnings.

lib/src/result.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'result/capture_transformer.dart';
 import 'result/error.dart';
 import 'result/release_transformer.dart';
 import 'result/value.dart';
@@ skipping 54 matching lines @@
   ///
   /// Alias for [ValueResult.ValueResult].
   factory Result.value(T value) = ValueResult<T>;
 
   /// Create a `Result` holding an error.
   ///
   /// Alias for [ErrorResult.ErrorResult].
   factory Result.error(Object error, [StackTrace stackTrace]) =>
       new ErrorResult(error, stackTrace);
 
-  // Helper functions.
-  static _captureValue(value) => new ValueResult(value);
-  static _captureError(error, stack) => new ErrorResult(error, stack);
-  static _release(Result v) {
-    if (v.isValue) return v.asValue.value;  // Avoid wrapping in future.
-    return v.asFuture;
-  }
-
   /// Capture the result of a future into a `Result` future.
   ///
   /// The resulting future will never have an error.
   /// Errors have been converted to an [ErrorResult] value.
-  static Future<Result> capture(Future future) {
-    return future.then(_captureValue, onError: _captureError);
+  static Future<Result/*<T>*/> capture/*<T>*/(Future/*<T>*/ future) {
+    return future.then((value) => new ValueResult(value),

[Lasse Reichstein Nielsen, 2016/03/29 21:53:59]

No <T> on the new ValueResult?

[nweiz, 2016/03/30 00:57:18]

It's inferred, but now that you mention it there should be one on the
ErrorResult since onError is pretty much untyped.

+        onError: (error, stackTrace) => new ErrorResult(error, stackTrace));
   }
 
   /// Release the result of a captured future.
   ///
   /// Converts the [Result] value of the given [future] to a value or error
   /// completion of the returned future.
   ///
   /// If [future] completes with an error, the returned future completes with
   /// the same error.
-  static Future release(Future<Result> future) {
-    return future.then(_release);
-  }
+  static Future/*<T>*/ release/*<T>*/(Future<Result/*<T>*/> future) async =>
+      (await future).asFuture;
 
   /// Capture the results of a stream into a stream of [Result] values.
   ///
   /// The returned stream will not have any error events.
   /// Errors from the source stream have been converted to [ErrorResult]s.
   ///
   /// Shorthand for transforming the stream using [captureStreamTransformer].

[Lasse Reichstein Nielsen, 2016/03/29 21:53:59]

That is not longer true, so remove this comment line.

It's also annoying that you have to create a new transformer for every call.
Type parameters suck! :)

[nweiz, 2016/03/30 00:57:18]

Done.

-  static Stream<Result> captureStream(Stream source) {
-    return source.transform(captureStreamTransformer);
-  }
+  static Stream<Result/*<T>*/> captureStream/*<T>*/(Stream/*<T>*/ source) =>
+      source.transform(new CaptureStreamTransformer<T>());
 
   /// Release a stream of [result] values into a stream of the results.
   ///
   /// `Result` values of the source stream become value or error events in
   /// the returned stream as appropriate.
   /// Errors from the source stream become errors in the returned stream.
   ///
   /// Shorthand for transforming the stream using [releaseStreamTransformer].
-  static Stream releaseStream(Stream<Result> source) {
-    return source.transform(releaseStreamTransformer);
-  }
+  static Stream/*<T>*/ releaseStream/*<T>*/(Stream<Result/*<T>*/> source) =>
+      source.transform(new ReleaseStreamTransformer<T>());
 
   /// Converts a result of a result to a single result.
   ///
   /// If the result is an error, or it is a `Result` value
   /// which is then an error, then a result with that error is returned.
   /// Otherwise both levels of results are value results, and a single
   /// result with the value is returned.
-  static Result flatten(Result<Result> result) {
-    if (result.isError) return result;
-    return result.asValue.value;
+  static Result/*<T>*/ flatten/*<T>*/(Result<Result/*<T>*/> result) {
+    if (result.isValue) return result.asValue.value;
+    return new ErrorResult/*<T>*/(
+        result.asError.error, result.asError.stackTrace);
   }
 
   /// Whether this result is a value result.
   ///
   /// Always the opposite of [isError].
   bool get isValue;
 
   /// Whether this result is an error result.
   ///
   /// Always the opposite of [isValue].
   bool get isError;
 
   /// If this is a value result, return itself.
   ///
   /// Otherwise return `null`.
   ValueResult<T> get asValue;
 
   /// If this is an error result, return itself.
   ///
   /// Otherwise return `null`.
-  ErrorResult get asError;
+  ErrorResult<T> get asError;
 
   /// Complete a completer with this result.
   void complete(Completer<T> completer);
 
   /// Add this result to an [EventSink].
   ///
   /// Calls the sink's `add` or `addError` method as appropriate.
   void addTo(EventSink<T> sink);
 
   /// Creates a future completed with this result as a value or an error.
   Future<T> get asFuture;
 }