Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: sandbox/linux/BUILD.gn

Issue 1841193002: 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use test() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-minor-renames
Patch Set: Test runner, backwards-compat with recipes, added sandbox_linux_unittests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/linux/BUILD.gn
diff --git a/sandbox/linux/BUILD.gn b/sandbox/linux/BUILD.gn
index e08f42b35f7ca259fe4a80bb9e3ccc506803c098..9de8e58f361c7662981c7ad7d144d3c98cd2f985 100644
--- a/sandbox/linux/BUILD.gn
+++ b/sandbox/linux/BUILD.gn
@@ -201,24 +201,14 @@ group("sandbox_linux_unittests_run") {
]
}
-if (is_android) {
- group("sandbox_linux_unittests_apk_run") {
- testonly = true
- deps = [
- ":sandbox_linux_unittests",
- ]
- }
-}
-
-# The main sandboxing test target. "sandbox_linux_unittests" cannot use the
-# test() template because the test is run as an executable not as an APK on
-# Android.
-executable("sandbox_linux_unittests") {
- testonly = true
+test("sandbox_linux_unittests") {
deps = [
":sandbox_linux_unittests_sources",
"//build/config/sanitizers:deps",
]
+ if (is_android) {
+ use_raw_android_executable = true
+ }
}
component("seccomp_bpf") {
@@ -454,23 +444,11 @@ if (compile_suid_client || is_nacl_nonsfi) {
}
if (is_android) {
- create_native_executable_dist("sandbox_linux_unittests_deps") {
+ # TODO(GYP) Delete this after we've converted everything to GN.
+ group("sandbox_linux_unittests_deps") {
testonly = true
- dist_dir = "$root_out_dir/sandbox_linux_unittests_deps"
- binary = "$root_out_dir/sandbox_linux_unittests"
deps = [
":sandbox_linux_unittests",
]
-
- if (is_component_build) {
- deps += [ "//build/android:cpplib_stripped" ]
- }
- }
-
- test_runner_script("sandbox_linux_unittests__test_runner_script") {
- test_name = "sandbox_linux_unittests"
- test_type = "gtest"
- test_suite = "sandbox_linux_unittests"
- isolate_file = "//sandbox/sandbox_linux_unittests_android.isolate"
}
}

Powered by Google App Engine
This is Rietveld 408576698