Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: build/config/android/internal_rules.gni

Issue 1841193002: 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use test() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-minor-renames
Patch Set: Test runner, backwards-compat with recipes, added sandbox_linux_unittests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index ac1c7cb3b8a31d069d7fc22536b2cb8ee4f73248..ba56851d4055866409ef7bb858be7325a1c0ad13 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -2073,22 +2073,32 @@ template("test_runner_script") {
"//build/android:test_runner_py",
]
+ test_runner_args = [
+ _test_type,
+ "--output-directory",
+ rebase_path(root_build_dir, root_build_dir),
+ ]
+
# apk_target is not used for native executable tests
# (e.g. breakpad_unittests).
if (defined(invoker.apk_target)) {
+ assert(!defined(invoker.executable))
deps += [ "${invoker.apk_target}__build_config" ]
_apk_build_config =
get_label_info(invoker.apk_target, "target_gen_dir") + "/" +
get_label_info(invoker.apk_target, "name") + ".build_config"
_rebased_apk_build_config = rebase_path(_apk_build_config, root_build_dir)
assert(_rebased_apk_build_config != "") # Mark as used.
+ } else if (_test_type == "gtest") {
+ assert(
+ defined(invoker.executable),
+ "Must defined either apk_target or executable for test_runner_script()")
jbudorick 2016/03/30 19:33:38 nit: s/defined/define/
agrieve 2016/03/30 19:52:57 Done.
+ test_runner_args += [
+ "--executable-path",
+ rebase_path(invoker.executable, root_build_dir),
+ ]
}
- test_runner_args = [
- _test_type,
- "--output-directory",
- rebase_path(root_build_dir, root_build_dir),
- ]
if (_test_type == "gtest") {
assert(defined(invoker.test_suite))
test_runner_args += [

Powered by Google App Engine
This is Rietveld 408576698