core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix test name Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp b/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

index d14eeb991c8428deabfe3b294dbb93c041d6815d..5a3db292e0f006c31a2d7693c98045daf9d0fc64 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

@@ -630,7 +630,7 @@ unsigned int CPDF_SyntaxParser::ReadEOLMarkers(FX_FILESIZE pos) {

CPDF_Stream* CPDF_SyntaxParser::ReadStream(CPDF_Dictionary* pDict,

uint32_t objnum,

uint32_t gennum) {

- CPDF_Object* pLenObj = pDict->GetElement("Length");

+ CPDF_Object* pLenObj = pDict->GetObjectBy("Length");

FX_FILESIZE len = -1;

CPDF_Reference* pLenObjRef = ToReference(pLenObj);