xfa/fxfa/parser/xfa_script_imp.cpp - Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_script_imp.cpp

Issue 1841173002: Rename GetElementValue() to GetDirectObject{By,At}(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use "At" for arrays. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_script_imp.cpp

diff --git a/xfa/fxfa/parser/xfa_script_imp.cpp b/xfa/fxfa/parser/xfa_script_imp.cpp

index e20a4e0b2af9c5b1998a94f44975b35ae759757b..a3ec7a6e67dfcc3077a5d8e6124b2fc464e732e0 100644

--- a/xfa/fxfa/parser/xfa_script_imp.cpp

+++ b/xfa/fxfa/parser/xfa_script_imp.cpp

@@ -292,7 +292,7 @@ void CXFA_ScriptContext::NormalPropertySetter(FXJSE_HOBJECT hObject,

}

CXFA_Node* pNode = ToNode(pObject);

CXFA_Node* pPropOrChild = NULL;

- const XFA_ELEMENTINFO* lpElementInfo = XFA_GetElementByName(wsPropName);

+ const XFA_ELEMENTINFO* lpElementInfo = XFA_GetObjectByByName(wsPropName);

if (lpElementInfo) {

pPropOrChild = pNode->GetProperty(0, lpElementInfo->eName);

} else {